Re: [PATCH v2] trace-cmd: prevent print_graph_duration bufferoverflow

[Chase Douglas]

On Tue, 2010-06-15 at 10:54 -0400, Steven Rostedt wrote:
> Quick note. Please send to my rostedt@xxxxxxxxxxx address. I may not see
> messages here for weeks at a time. I author patches with my RH account
> just to "advertise" who I work for. But I sign-off-by with the account I
> want people to send to.

Ahh. I took the email address from the authors line like you said :). Is
this standard practice for others as well?

> On Tue, 2010-06-15 at 10:47 -0400, Chase Douglas wrote:
> > Passing n > sizeof(string) to snprintf can cause a glibc buffer overflow
> > condition. We know the exact size of nsecs_str, so use it along with the
> > the math to determine the longest string size we want.
> > 
> > Note that an overflow isn't really possible given the format of the
> > string. However, glibc would abort due to a runtime check.
> > 
> > Signed-off-by: Chase Douglas <chase.douglas@xxxxxxxxxxxxx>
> 
> Thanks!
> 
> Can you write a similar patch for the Linux kernel too. It may need to
> go to stable as well.

Sure

-- Chase

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/