Re: [PATCH -v18 00/37] Use lmb with x86

[Yinghai Lu]

On 06/16/2010 01:41 AM, Benjamin Herrenschmidt wrote:
> On Tue, 2010-06-15 at 23:10 -0700, Linus Torvalds wrote:
>> On Tuesday, June 15, 2010, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>>>
>>>  46 files changed, 1476 insertions(+), 1282 deletions(-)
>>
>> So what was the advantage again? It's adding more lines than it
>> removes. Wasn't the point to simplify things, not make them bigger?
> 
> I -think- the point is that once that's done, you can remove a whole lot
> of gunk that was added such as the kernel/range.c caca, etc...
> (basically, x86 gunk gratuituously made generic and that should really
> just die instead).

right.

this patch include seperate bootmem.c into bootmem.c and nobootmem.c to reduce
MACRO according Ingo and others.
 mm/bootmem.c                    |  165 +----------
 mm/nobootmem.c                  |  415 +++++++++++++++++++++++++++

later will
1. remove x86 own copy for find_from_low_to_high after more testing with high to low. that is about 200 lines code.
2. replace range.c with lmb. but need to expand lmb little bit
   like add can_resize and can_merge to be attribute of lmb_type.

Thanks

Yinghai Lu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/