RE: [PATCH 5/12] scsi: megaraid_sas - Online Controller Reset(OCR): Add and initialize the OCR relaed variable

[Yang, Bo]

James,

Thanks, I will re-submit the patches 5-12.

Regards,

Bo Yang

-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@xxxxxxx] 
Sent: Thursday, June 17, 2010 12:20 PM
To: Yang, Bo
Cc: 'linux-scsi@xxxxxxxxxxxxxxx'; 'akpm@xxxxxxxx'; 'linux-kernel@xxxxxxxxxxxxxxx'
Subject: Re: [PATCH 5/12] scsi: megaraid_sas - Online Controller Reset (OCR): Add and initialize the OCR relaed variable

On Wed, 2010-06-09 at 21:54 -0600, Yang, Bo wrote:
> To support online controller reset, driver need to define some
> instance based variable and initialize them.

This doesn't compile:

  CC [M]  drivers/scsi/megaraid/megaraid_sas.o
drivers/scsi/megaraid/megaraid_sas.c: In function
âmegasas_deplete_reply_queueâ:
drivers/scsi/megaraid/megaraid_sas.c:2090: warning: unused variable
âfw_stateâ
drivers/scsi/megaraid/megaraid_sas.c: In function âmegasas_init_mfiâ:
drivers/scsi/megaraid/megaraid_sas.c:3023: error: âstruct
megasas_ctrl_propâ has no member named âOnOffPropertiesâ
drivers/scsi/megaraid/megaraid_sas.c: In function âmegasas_probe_oneâ:
drivers/scsi/megaraid/megaraid_sas.c:3486: error:
âprocess_fw_state_change_wqâ undeclared (first use in this function)
drivers/scsi/megaraid/megaraid_sas.c:3486: error: (Each undeclared
identifier is reported only once
drivers/scsi/megaraid/megaraid_sas.c:3486: error: for each function it
appears in.)

Because OnOffProperties structure is defined in patch 6/12 as is the
process_fw_state_change_wq function.

I've got 1-4 ... please resubmit 5-12 so they actually build in the
order submitted.

Thanks,

James


N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ0¶ìh®å’i