Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but not used

[David Howells]

Justin P. Mattock <justinmattock@xxxxxxxxx> wrote:

> +		if (ret) {
> +			printk(KERN_WARNING "dev%d: Failed to get exception\n", ret);
> +		}

That's not a good warning because it's a meaningless string and you're passing
the error number to the dev%d.

Better would perhaps be:

	"dev%d: Failed to create physical_node sysfs link: %d\n"

Note also that you're only checking the result of one sysfs_create_link().
You should probably check both.

Also you're introducing a pair of unnecessary braces as there's only one
statement in the if-body.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/