Re: [PATCH 1/2] Makefile: fix missing dash when using make LOCALVERSION=xxx

[Cong Wang]

On 06/29/10 02:46, David Rientjes wrote:
> On Mon, 28 Jun 2010, Cong Wang wrote:
>
> > But in your patch description, you said:
> >
> >      Without CONFIG_LOCALVERSION_AUTO, "make" results in v2.6.32-rc4+
> >      unless the repository is at the Linux v2.6.32-rc4 commit (in which
> >      case the version would be v2.6.32-rc4).  If "make LOCALVERSION=kbuild"
> >      were used, it results in v2.6.32-rc4-kbuild.
> >
> > So, shouldn't that be "make LOCALVERSION=-kbuild"?
>
> Yup, that's what it should have said.  That doesn't mean that we need to
> change the long-standing behavior of LOCALVERSION= to add an implied `-',
> though.

Ok, but your patch description is the only doc I found, so... :)

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/