Re: [PATCH 5/6] usb/gadget: Do not take BKL for gadget->ops->ioctl

From: David Brownell
Date: Tue Jun 29 2010 - 10:08:55 EST



> Date: Friday, June 18, 2010, 6:59 AM
> On Tue, 01 Jun 2010 23:04:44 +0200,
> Arnd Bergmann <arnd@xxxxxxxx>
> wrote:
> > There is no gadget driver in the tree that
> > actually implements the ioctl operation, so
> > obviously it is not necessary to hold the
> > BKL around the call.

The original gadgetfs code used it as a
passthrough to controller-specific ops, as
I recall. Not much used, right.

And yes, I suspect someone just threw
some BKL stuff here without actually
analysing whether it was necessary.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/