Re: [PATCH] dynamic_debug: allow to set dynamic debug flags rightat module load time

[Jason Baron]

On Tue, Jun 29, 2010 at 01:25:29PM +0200, Roman Fietze wrote:
> Hello Jason, hello LKML,
> 
> On Friday 28 May 2010 15:55:49 Jason Baron wrote:
> 
> > right, i think we want to add something inside ddebug_add_module()
> > that recognizes if the module was loaded with verbose=1. I think you
> > can get at the parameters via module->kp, which we need to pass in
> > as well.
> 
> Yes, I would first check if there's a section named "__verbose" as it
> is right now. If yes, I would search the already setup module->kp for
> the used parameter.
>
> 
> Proposals, not being sure how to implement that right now:
> 
> Default is to search e.g. for param "dprintk".
> 

make sense.

> Provide a macro to override that default, e.g.
> DPRINTK_PARAM("verbose")
>

why would we want to override it?
 
> If the default or defined bool or other integer parameter is unequal
> to 0 enable the p-flag on module load for all debug statements of this
> module.
> 
> 
> Questions just in case the proposal is kind of ok:
> 
> Prepare the code to allow the setting of different future flags
> unequal to 'p'?
> 
> Use a charp param instead of a bool to allow that?
> 

yes, we might eventually want more than a bool, but unless you have a
specific case in mind, I would keep as simple as possible for now.

thanks,

-Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/