Re: [PATCH] serial: fix rs485 for atmel_serial on avr32

From: Andrew Morton
Date: Thu Jul 01 2010 - 18:39:23 EST


On Tue, 29 Jun 2010 19:35:39 +0200
Peter H__we <PeterHuewe@xxxxxx> wrote:

> From: Peter Huewe <peterhuewe@xxxxxx>
>
> This patch fixes a build failure [1-4] in the atmel_serial code introduced by
> patch the patch ARM: 6092/1: atmel_serial: support for RS485
> communications (e8faff7330a3501eafc9bfe5f4f15af444be29f5)
>
> The build failure was caused by missing struct field and missing defines
> for the avr32 board - the patch fixes this.
>
> Signed-off-by: Peter Huewe <peterhuewe@xxxxxx>
> ---
> Despite so many reviewers of the original patch no one seemed to
> notice this issue :/
>
> KernelVersion: linux-next-20100629
>
> References:
> [1] http://kisskb.ellerman.id.au/kisskb/buildresult/2575242/ - first failure
> in linux-next, may 11th
> [2] http://kisskb.ellerman.id.au/kisskb/buildresult/2816418/ - still
> exists as of today
> [3] http://kisskb.ellerman.id.au/kisskb/buildresult/2617511/ - first
> failure in Linus' tree - May 20th - did really no one notice this?!
> [4] http://kisskb.ellerman.id.au/kisskb/buildresult/2813956/ - still
> exists in Linus' tree as of today
>
> arch/avr32/include/asm/ioctls.h | 3 +++
> arch/avr32/mach-at32ap/include/mach/board.h | 2 ++
> drivers/serial/atmel_serial.c | 1 +
> 3 files changed, 6 insertions(+), 0 deletions(-)

ooookay. Thanks, I'll take it if nobody else will ;)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/