Re: [PATCH 0/2] use q->prep_rq_fn for flush requests instead ofq->prepare_flush_fn()

[FUJITA Tomonori]

On Fri,  2 Jul 2010 16:33:23 +0900
FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> wrote:

> scsi-ml builds flush requests via q->prepare_flush_fn(), however,
> builds discard requests via q->prep_rq_fn.
> 
> Using two different mechnisms for the similar requests (building
> commands in SCSI ULD) doesn't make sense.
> 
> Handing both via q->prep_rq_fn makes the code simpler.
> 
> We could kill q->prepare_flush_fn(). Except for ide, all the users
> just mark flush requests. They can use REQ_FLUSH flag instead. Ide can
> do like SCSI.
> 
> ==
>  block/blk-barrier.c |   12 ++++--------
>  drivers/scsi/sd.c   |   26 ++++++++++++++++----------
>  include/linux/bio.h |    2 ++
>  3 files changed, 22 insertions(+), 18 deletions(-)

Oops, this can be applied to Jens' for-2.6.36. It can't to scsi-misc
due to the discard patches.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/