Re: [PATCH/RFC] hwmon: Add support for W83667HG-B

[Jean Delvare]

On Fri, 2 Jul 2010 01:07:04 -0700, Guenter Roeck wrote:
> On Fri, Jul 02, 2010 at 03:20:11AM -0400, Jean Delvare wrote:
> > On Thu, 1 Jul 2010 15:02:15 -0700, Guenter Roeck wrote:
> > > @@ -63,6 +64,7 @@ static const char * w83627ehf_device_names[] = {
> > >  	"w83627dhg",
> > >  	"w83627dhg",
> > >  	"w83667hg",
> > > +	"w83667hg-b",
> > 
> > Dashes aren't allowed in hwmon device names. For consistency with what
> > we did for the W83627DHG-Pg, you should simply drop the "-b". It's a small
> > detail of little interest for the user anyway.
>
> Ok. Actually, since the only real difference was in the registers which
> are not not used anywhere, I'll drop the enum type (w83667hg_b) as well.

Makes sense. It can be added later if needed.

> I'll also add a check for the HG-I.

Do you have a datasheet for that one too?

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/