Re: [PATCH v4 5/6] KVM: MMU: combine guest pte read between walkand pte prefetch

[Xiao Guangrong]

Avi Kivity wrote:

> 
> Note: I think we have to check _after_ kvm_mmu_get_page(), otherwise we
> might be checking a page that is not write-protected and can change again.
> 
> So the logic needs to be something like
> 
> for_each_shadow_entry:
>     if (!last_level && !present(*spte))
>         kvm_mmu_get_page
>     verify gpte
>     if (last_level)
>         mmu_set_spte()
> 

Agree! Will do it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/