Re: Fwd: Possible bug in net/ipv4/route.c?

From: Eric Dumazet
Date: Mon Jul 05 2010 - 09:30:19 EST


Le lundi 05 juillet 2010 Ã 20:06 +0800, Herbert Xu a Ãcrit :
> Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> >
> >> 2) The layer using skb->cb[] should clear this area after use and
> >> before handing the skb to another layer. Ubicom should modify the
> >> driver to clear the skb->cb[] area before sending it up the line.
> >>
> >
> > This is the right option. If you use one word in cb[], only your driver
> > knows how to clear it efficiently.
>
> Absolutely not! No protocol stack should rely on an external skb
> having a zero cb.
>

Why do we clear full 48 bytes skb->cb[] in skb_alloc(), if no protocol
stack should rely it being zero ?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/