Re: [PATCH] Staging: dt3155: fix coding style issues indt3155_drv.c

[Simon Horman]

On Tue, Jul 06, 2010 at 12:25:35PM -0500, Aldo Cedillo wrote:
> > diff --git a/drivers/staging/dt3155/dt3155_drv.c b/drivers/staging/dt3155/dt3155_drv.c
> > index 66db878..f6edd66 100644
> > --- a/drivers/staging/dt3155/dt3155_drv.c
> > +++ b/drivers/staging/dt3155/dt3155_drv.c
> > @@ -308,33 +308,42 @@ static void dt3155_isr(int irq, void *dev_id, struct pt_regs *regs)
> > Â#endif
> > Â Â Â Â Â Â Â Â Â Â Â Âif (fb->nbuffers > 2) {
> > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âif (!are_empty_buffers(minor)) {
> > - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â /* The number of active + locked buffers is
> > - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â* at most 2, and since there are none empty, there
> > - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â* must be at least nbuffers-2 ready buffers.
> > - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â* This is where we 'drop frames', oldest first. */
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â /* The number of active +
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â* locked buffers is at most 2,
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â* and since there are none empty,
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â* there must be at least nbuffers-2
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â* ready buffers.
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â* This is where we 'drop frames',
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â* oldest first. */
> > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âpush_empty(pop_ready(minor), Âminor);
> > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â}
> >
> 
> In the CodingStyle in the kernel you can read:
> 
> The preferred style for long (multi-line) comments is:
> 
>         /*
>          * This is the preferred style for multi-line
>          * comments in the Linux kernel source code.
>          * Please use it consistently.
>          *
>          * Description:  A column of asterisks on the left side,
>          * with beginning and ending almost-blank lines.
>          */
> 
> Again I ask about the coding style because I have seen in many parts of the
> kernel I've seen discrepancies with what is said in the CodingStyle file. So
> I want to get it clear maybe I can help to clean those things.

I believe that you will find both of the following styles in abundance
and that both are acceptable.

   /*
    * This
    * is a multi-line comment
    */

And

   /* This
    * is a also multi-line comment
    */

Though one may be more acceptable to a given maintainer than the other.
Other variants may also be common and acceptable to some maintainers,
which I suspect is why checkpatch.pl is lenient.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/