Re: [PATCH] serial: fix termios settings in open

[Greg KH]

On Tue, Jun 29, 2010 at 10:31:40PM +0200, Arnd Bergmann wrote:
> Move termios initialization in open into uart_dtr_rts to make sure
> it always gets called when necessary. Based on a suggestion from
> Alan Cox.
> 
> Alan writes:
> Ok this sort of makes sense. Something isn't getting initialised and both
> getty and minicom will do a termios set which is sorting it out.
> This is occurring because the generic block_til_ready sets
> ASYNCB_NORMAL_ACTIVE so the termios updating gets skipped.
> 
> This patch should cure it and then we can think about doing it more
> elegantly by getting the serial layer to use tty_port_open, kfifo and
> the like and removing the tons of repeated crap in all the drivers.
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Reported-by: Tony Luck <tony.luck@xxxxxxxxx>
> Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> Cc: Tony Luck <tony.luck@xxxxxxxxx>
> ---
> 
> Greg, please apply to you tty series. I thought there was a bug
> in this patch but it turns out that this was incorrect. There
> is still something fishy on my system with hardware flow control,
> but it seems to be a preexisting condition, so this patch is actually
> good, unlike what I said before. Please apply next to "serial: Use
> block_til_ready helper", which introduces the ploblem.

Now applied, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/