Re: [PATCH][GIT PULL][for 2.6.35] tracing: Add alignment tosyscall metadata declarations

From: Steven Rostedt
Date: Fri Jul 09 2010 - 20:26:13 EST


On Fri, 2010-07-09 at 14:25 -0700, Linus Torvalds wrote:
> On Fri, Jul 9, 2010 at 1:33 PM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> >
> > Something like this:
> > (whitespace damaged)
> > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> > index 48c5299..64430d3 100644
> > --- a/include/asm-generic/vmlinux.lds.h
> > +++ b/include/asm-generic/vmlinux.lds.h
> > @@ -133,7 +133,8 @@
> > #endif
> >
> > #ifdef CONFIG_FTRACE_SYSCALLS
> > -#define TRACE_SYSCALLS() VMLINUX_SYMBOL(__start_syscalls_metadata) = .; \
> > +#define TRACE_SYSCALLS() . = ALIGN(8); \
> > + VMLINUX_SYMBOL(__start_syscalls_metadata) = .; \
> > *(__syscalls_metadata) \
> > VMLINUX_SYMBOL(__stop_syscalls_metadata) = .;
> > #else
>
> If this is confirmed to fix it, then I would much prefer this version.

Zeev,

Can you try Sam's version and remove mine. I'd like to see if that fixes
the issue too.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/