Re: [patch 134/149] x86, paravirt: Add a global synchronization point for pvclock
From: Linus Torvalds
Date: Tue Jul 13 2010 - 13:51:31 EST
On Tue, Jul 13, 2010 at 10:25 AM, Peter Palfrader <peter@xxxxxxxxxxxxx> wrote:
>
> Linus's patch touches __xchg() whereas we're using __cmpxchg() in this
> particular case I think.
>
> At least, applying it to my 2.6.32.16 tree didn't help, last_value was
> still read-only. Or I backported it wrong.
No, you didn't back-port it wrong. I just didn't fix the right part. I
thought the PV code used xchg, not cmpxchg, so I only patched that.
But cmpxchg has the exact same issue.
Does this fix it?
Again: UNTESTED.
Linus
Attachment:
diff
Description: Binary data