Re: [PATCH] workqueue: fix locking in retry path of maybe_create_worker()

[Tejun Heo]

On 07/12/2010 03:23 PM, Yong Zhang wrote:
> On Mon, Jul 12, 2010 at 10:53:18AM +0200, Tejun Heo wrote:
>> maybe_create_worker() mismanaged locking when worker creation fails
>> and it has to retry.  Fix locking and simplify lock manipulation.
>>
>> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
>> Reported-by: Yong Zhang <yong.zhang@xxxxxxxxxxxxx>
>> ---
>> Heh, that was stupid.  Thanks a lot for spotting it.  I simplified
>> things a bit there as there's no reason to repeatedly lock and unlock
>> there.  Does this look good to you?
> 
> Yeah, this is better.

Pushed out to for-next-candidate branch.

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-next-candidate

I'll push it to linux-next the next week.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/