Re: [PATCH 1/7] memcg: sc.nr_to_reclaim should be initialized

[KOSAKI Motohiro]

> On Fri, Jul 16, 2010 at 07:13:31PM +0900, KOSAKI Motohiro wrote:
> > Currently, mem_cgroup_shrink_node_zone() initialize sc.nr_to_reclaim as 0.
> > It mean shrink_zone() only scan 32 pages and immediately return even if
> > it doesn't reclaim any pages.
> > 
> 
> Do you mean it immediately returns once one page is reclaimed? i.e. this
> check
> 
>                if (nr_reclaimed >= nr_to_reclaim && priority < DEF_PRIORITY)
>                         break;

Strictly speaking, once SWAP_CLUSTER_MAX batch is scanned. no need
to reclaim pages at all.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/