Re: [PATCH wq#for-linus] workqueue: workqueue_cpu_callback()should be cpu_notifier not hotcpu_notifier

From: Markus Trippelsdorf
Date: Mon Aug 09 2010 - 05:46:37 EST


On Mon, Aug 09, 2010 at 11:36:20AM +0200, Tejun Heo wrote:
> Commit 6ee0578b (workqueue: mark init_workqueues as early_initcall)
> made workqueue SMP initialization depend on workqueue_cpu_callback(),
> which however was registered as hotcpu_notifier() and didn't get
> called if CONFIG_HOTPLUG_CPU is not set. This made gcwqs on non-boot
> CPUs not create their initial workers leading to boot failures. Fix
> it by making it a cpu_notifier.
>
> So, something like this. Can you please verify the fix?

This fixes the boot problem here. Thanks.
(The drm delayed enqueue problem, which I mentioned earlier still
persists.)

--
»A man who doesn't know he is in prison can never escape.«
William S. Burroughs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/