Re: [PATCH] MIPS: remove RELOC_HIDE on __pa_symbol

[Namhyung Kim]

2010-08-09 (ì), 13:21 +0100, Ralf Baechle:
> On Sun, Aug 08, 2010 at 10:15:04PM -0700, David Daney wrote:
> > Maybe you could explain in more detail the problems you are having
> > with the current definition of __pa_symbol().  I would be hesitant
> > to change this bit of black magic unless there is a concrete problem
> > you are trying to solve.
> 
> RELOC_HIDE was originally added by 6007b903dfe5f1d13e0c711ac2894bdd4a61b1ad
> (lmo) rsp. 8431fd094d625b94d364fe393076ccef88e6ce18 (kernel.org).  A
> discussion can be found in lkml posting
> a2ebde260608230500o3407b108hc03debb9da6e62c@xxxxxxxxxxxxxx> which is
> archived at
> 
>     http://lists.linuxcoding.com/kernel/2006-q3/msg17360.html
> 
> I felt this was dubious by the time it was added and probably should go?
> 
>   Ralf

Hi,

I've sent basically same patch to x86 folks [1] and they said there is a
possiblility of miscompilation on gcc 3. I am not sure the same goes
here on mips but it might be safer to keep it. Sorry for the noise ;-(

[1] http://lkml.org/lkml/2010/8/8/138


-- 
Regards,
Namhyung Kim


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/