RE: [rtc-linux] [PATCH 1/2] rtc: rtc-lpc32xx: Introduce RTC driverfor the LPC32XX SoC

[Kevin Wells]

Hi Alessandro,

Thanks for helping to review this.

> 
> > +
> > +	retval = request_irq(rtc->irq, lpc32xx_rtc_alarm_interrupt,
> > +		IRQF_DISABLED, "rtcalarm", rtc);
> > +	if (retval < 0) {
> > +		dev_err(&pdev->dev, "Can't request interrupt\n");
> > +		goto err_free_irq;
> > +	}
> 
>  if the driver can work without the alarm irq you
>  can convert this to a non fatal warning.
> 
>  having an rtc without alarms is much better than having none.
> 

Good suggestion. I'll change this.

> --
> 
>  Best regards,
> 
>  Alessandro Zummo,
>   Tower Technologies - Torino, Italy
> 
>   http://www.towertech.it
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/