Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35

[Masayuki Ohtake]

Hi Greg,

> Use the 'bool' type, and 'true' and/or 'false' keywords instead.  That
> is the proper C idiom.
I can do well.

Thanks, Ohtake.

----- Original Message ----- 
From: "Greg KH" <gregkh@xxxxxxx>
To: "Masayuki Ohtake" <masa-korg@xxxxxxxxxxxxxxx>
Cc: "Wang, Qi" <qi.wang@xxxxxxxxx>; <meego-dev@xxxxxxxxx>; "LKML" <linux-kernel@xxxxxxxxxxxxxxx>; "Wang, Yong Y"
<yong.y.wang@xxxxxxxxx>; "Khor, Andrew Chih Howe" <andrew.chih.howe.khor@xxxxxxxxx>; <arjan@xxxxxxxxxxxxxxx>
Sent: Wednesday, August 11, 2010 1:39 PM
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35


> On Wed, Aug 11, 2010 at 01:34:33PM +0900, Masayuki Ohtake wrote:
> > Hi Qi-san
> >
> > I have found Macro 'TRUE' and 'FALSE' are used as setting value in the driver; still,
> > can't I use TRUE/FALSE macro ?
> > If not, How should we implement ?
>
> Use the 'bool' type, and 'true' and/or 'false' keywords instead.  That
> is the proper C idiom.
>
> thanks,
>
> greg k-h
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/