Re: [PATCH] matroxfb: fix incorrect use of memcpy_toio()

[Ondrej Zary]

On Wednesday 11 August 2010 22:41:36 Andrew Morton wrote:
> On Wed, 11 Aug 2010 22:27:42 +0200
>
> Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx> wrote:
> > Fix incorrect use of memcpy_toio() in matroxfb that broke in 2.6.34 on
> > x86.
>
> Thanks.
>
> What was incorrect about it?  And what is the user-visible effect of
> this regression?

Screen is completely corrupted since 2.6.34. Bisection revealed that it's 
caused by commit 6175ddf06b6172046a329e3abfd9c901a43efd2e. H. Peter Anvin 
explained that memcpy_toio() does not copy data in 32bit chunks anymore on 
x86.

See: http://lkml.org/lkml/2010/8/2/409

-- 
Ondrej Zary
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/