Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work-on-i386.patchadded to -mm tree

From: H. Peter Anvin
Date: Wed Aug 11 2010 - 21:37:49 EST


On 08/11/2010 05:33 PM, Andrew Morton wrote:
>
> Not very well.
>
> + rc = copy_from_user(&record_id, (void __user *)arg,
> + sizeof(u64));
>
> better to use sizeof(record_id).
>
> Where's Len??
>
> Anyway, this should be fixed in x86 core, I suspect.

Agreed. Looking at it now.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/