RE: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to2.6.35

[Wang, Qi]

> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxx]
> Sent: Thursday, August 12, 2010 10:00 AM
> To: Wang, Qi
> Cc: Masayuki Ohtake; meego-dev@xxxxxxxxx; LKML; Wang, Yong Y; Khor,
> Andrew Chih Howe; arjan@xxxxxxxxxxxxxxx
> Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to
> 2.6.35
> 
> On Thu, Aug 12, 2010 at 09:13:24AM +0800, Wang, Qi wrote:
> > > -----Original Message-----
> > > From: Greg KH [mailto:gregkh@xxxxxxx]
> > > Sent: Wednesday, August 11, 2010 11:15 PM
> > > To: Masayuki Ohtake
> > > Cc: meego-dev@xxxxxxxxx; LKML; Wang, Qi; Wang, Yong Y; Khor, Andrew
> > > Chih Howe; arjan@xxxxxxxxxxxxxxx
> > > Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to
> > > 2.6.35
> > >
> > > On Wed, Aug 11, 2010 at 04:29:25PM +0900, Masayuki Ohtake wrote:
> > > > Hi Greg,
> > > >
> > > > > Do they all have to be ioctls?  What exactly are they doing?
> > > > I think using ioctl is common for this patch.
> > >
> > > "Common" is not ok, right?
> > >
> > > > Do you think that using ioctl is NOT appropriate for this patch?
> > >
> > > Yes.
> > >
> > > > Let me know your intension in more detail.
> > >
> > > Please express yours.  Why do you feel you need these to be ioctls?
> > > What exactly are they doing?  Where is the documentation for them all?
> 
> You forgot to answer this.
Ohtake-san,

Please answer this question asap.
> 
> > > > > And are they 32/64bit safe?
> > > > Only 32bit support.
> > >
> > > That's an obvious problem that needs to be resolved, right?
> > The Tunnelcreak processor (A kind of Atom-based processor) only
> > supports 32b, so PCH drivers only support 32b.
> > They can make it 32/64 compatible, but it's difficult to test them,
> > because there're no 64b Atom-based platform have those PCH devices.
> 
> But that does not mean you should not be using the proper types and
> other things necessary for proper ioctl usage.
> 
> As you failed to describe what any of these ioctls do, I can't recommend
> that you have any of them in the driver.
Ohtake-san, Please solve 32b/64b safe issue asap.
> 
> sorry,
> 
> greg k-h
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ0¶ìh®å’i