Re: [PATCH] ARM: Fix gen_nand probe structures contents

From: Marek Vasut
Date: Wed Aug 11 2010 - 22:44:05 EST


Dne Ät 12. srpna 2010 03:21:52 David Woodhouse napsal(a):
> On Thu, 2010-08-12 at 02:14 +0100, Marek Vasut wrote:
> > These three platforms didn't properly fill nr_chips in gen_nand
> > registration and
> > therefore depended on gen_nand bug fixed by the following patch:
> >
> > "mtd: gen_nand: fix support for multiple chips"
> >
> > Signed-off-by: Marek Vasut <marek.vasut@xxxxxxxxx>
>
> Thanks. I've applied that to the mtd-2.6.git tree, which has a few
> straggling commits I'll be asking Linus to pull shortly.
>
> In case there are any more, would you care to complement it with a check
> in the driver that detects the nonsensical case of nr_chips == 0,
> assumes it means 1, and also warns about it?

I checked whole arch-arm and there are no more. nr_chips check would be a nice
thing, I was thinking of it already when I sent the first patch. I just checked
the other archs and there are more breaks. I'll implement the check in a
separate patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/