Re: [PATCH] DRM: Replace kmalloc/memset combos with kzalloc

[Kristian HÃgsberg]

On Wed, Aug 11, 2010 at 3:58 PM, Davidlohr Bueso <dave@xxxxxxx> wrote:
> On Wed, 2010-08-11 at 07:35 -0700, Joe Perches wrote:
>> On Wed, 2010-08-11 at 09:18 -0400, Davidlohr Bueso wrote:
>> > memory allocation in drm_bufs.c is followed by initializing the memory with 0.
>> >
>> > Replace the use of kmalloc+memset with kzalloc.
>>
>> Perhaps kzalloc's with a multiply could/should also be converted
>> to kcalloc.
>>
>> > + Â entry->buflist = kzalloc(count * sizeof(*entry->buflist), GFP_KERNEL);
>>
>> Â Â Â entry->buflist = kcalloc(count, sizeof(*entry->buflist), GFP_KERNEL);
>>
>> etc.
>>
>> > + Â entry->buflist = kzalloc(count * sizeof(*entry->buflist), GFP_KERNEL);
>> > + Â entry->seglist = kzalloc(count * sizeof(*entry->seglist), GFP_KERNEL);
>> > + Â entry->buflist = kzalloc(count * sizeof(*entry->buflist),
>> > + Â entry->buflist = kzalloc(count * sizeof(*entry->buflist),
>>
>
> Doable, but don't see much difference. David, what do you think?

kcalloc does an integer overflow check, plus it's nice to be explicit
about allocating a number of elements of a certain size in the API.

Kristian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/