Re: [PATCH 1/2] fs/ocfs2/dlm: Eliminate update oflist_for_each_entry loop cursor

From: Joel Becker
Date: Thu Aug 12 2010 - 05:33:26 EST


On Thu, Aug 12, 2010 at 07:46:13AM +0200, Julia Lawall wrote:

> This seems a bit ugly to me, since it exposes the implementation of the
> list abstraction. What about the following:

Actually, we're going to go back to the original list_for_each()
and list_entry() version. It's a well understood idiom.
We're also going to re-audit the rest of the patch that changed
list_for_each() to list_for_each_entry(), just in case we missed another
semantic error.

Joel

--

Life's Little Instruction Book #30

"Never buy a house without a fireplace."

Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker@xxxxxxxxxx
Phone: (650) 506-8127
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/