Re: [PATCH 1/1] mouse: add qci touchpad driver

[Trilok Soni]

Hi David,

On 8/11/2010 4:50 AM, David Brown wrote:
> On Sat, Aug 07, 2010 at 04:14:54PM +0530, Trilok Soni wrote:
> 
>>> +
>>> +/*
>>> + * Driver communicates over i2c to nuvoTon WPCE775x Embedded Controller,
>>> + * which has touchpad attached through PS/2 interface.
>>> + */
>>
>> Why this driver is not developed through MFD architecture then? nuvoTon chip
>> looks like multi-function chip, isn't it?
> 
> It is, in the sense that it does multiple things.  But, for this
> particular device, it makes the keyboard available as an i2c device.
> I don't see any particular reason to tie that to other functionality
> that the chip provides.

Ok, agreed. Neil, please submit a new patch with addressing other comments. Thanks.

---Trilok Soni
-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/