Re: [PATCH 1/2] x86-32: Fix crashes with CPU hotplug on AMDmachines

[Joerg Roedel]

On Thu, Aug 12, 2010 at 08:34:37AM -0700, H. Peter Anvin wrote:

> Agreed.  I do have a concern about the kernel page tables not being
> synchronized into trampoline_pg_dir (it's only an issue for 32-bit
> !PAE), so at the very least we need to keep an eye out for it...

Great.

The synchronization problem might be real. The cpu_init function uses
per-cpu variables which might not be present in the early synced
tramponline page table (iirc). The change to swapper_pg_dir and the
global tlb flush should probably be moved to the very beginning of the
start_secondary function.

	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/