On 05/21/10 07:52, Hemanth V wrote:From: Hemanth V <hemanthv@xxxxxx>
Date: Thu, 20 May 2010 20:18:17 +0530
Subject: [PATCH] input: CMA3000 Accelerometer Driver
This patch adds support for CMA3000 Tri-axis accelerometer, which
supports Motion detect, Measurement and Free fall modes.
CMA3000 supports both I2C/SPI bus for communication, currently the
driver supports I2C based communication.
Driver reports acceleration data through input subsystem and supports
sysfs for configuration changes.
This is V2 of patch, which fixes open source review comments
Hi,
The driver is nice and clean.
Still leaving aside the long argued question of whether this should be
in input. If you care for my views on that there are plenty or other
threads! There are a few things I'd still like to suggest: