Re: EXPORT_SYMBOL(fat_get_block)

From: Greg KH
Date: Fri Aug 13 2010 - 13:54:15 EST


On Fri, Aug 13, 2010 at 10:45:39AM -0700, David Cross wrote:
> Hello Hirofumi,
> I would like to export this symbol from the vfat code and add this patch
> to the Linux kernel. You are listed as the MAINTAINER for FAT and VFAT.
> As such, I need your approval to do it.
> The reason that I need to export this symbol is to allow for file based
> DMA in which the file needs to be pre-allocated. The pre-allocated block
> addresses are passed to a DMA engine which then directly transfers the
> data to non-volatile storage.
> Please let me know if you have any objections to exporting this symbol
> or if you need additional information from me concerning this change
> request. I am happy to answer any questions that you may have about this
> in the meantime.

Wait, _I_ have an objection to exporting this symbol.

I really don't think it is needed at this point in time, as we really
need to figure out exactly what your driver is doing to want to need to
call this function.

So please, let's not export it for now, when we get to the point that we
all agree that this driver is doing the "correct" thing, then we can
export the symbol, ok?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/