Re: [PATCH] kvm: make mmu_shrink() fit shrinker's requirement

From: Dave Hansen
Date: Fri Aug 13 2010 - 16:10:43 EST


On Thu, 2010-08-05 at 12:28 +0300, Avi Kivity wrote:
> On 08/04/2010 10:13 AM, Lai Jiangshan wrote:
> > mmu_shrink() should attempt to free @nr_to_scan entries.
>
> This conflicts with Dave's patchset.
>
> Dave, what's going on with those patches? They're starting to smell.

These seem to fix the original problem reporter's issue. They were run
with 64 guests on a 32GB machine. No stability problems popped up in
this testing, or since I last sent the patches to you. The results from
both the test with only the first four patches and with the entire set
of nine looked pretty identical.

That tells me that we should only push the first four for now:

abstract kvm x86 mmu->n_free_mmu_pages
rename x86 kvm->arch.n_alloc_mmu_pages
replace x86 kvm n_free_mmu_pages with n_used_mmu_pages
create aggregate kvm_total_used_mmu_pages value


-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/