Re: [PATCH 06/11] rwsem: wake queued readers when writer blocks onactive read lock

[Michel Lespinasse]

On Fri, Aug 13, 2010 at 4:38 PM, Tony Luck <tony.luck@xxxxxxxxx> wrote:
> Aha!. I think I found it.
>
> This embarrassing declaration in ia64's asm/atomic.h:
>
> static __inline__ int
> ia64_atomic64_add (__s64 i, atomic64_t *v)
>
> looks to be the key.  Obviously it would be better to return all
> 64 bits of the answer using "long" rather than just 32 bits with "int".

Aha, good catch. Thanks for going to the bottom of this, it would have
taken me forever to figure it out (and I could not test this).

BTW there seems to be the same issue in ia64_atomic64_sub() too
(though I wonder if that ever gets used :)

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/