Re: [PATCH 3/9] RapidIO: Add the ingress port number into the RIOswitch data structure

From: Micha Nelissen
Date: Mon Aug 16 2010 - 08:14:59 EST


Alexandre Bounine wrote:
A switch ingress port number has to be saved for software assisted error
recovery from the error-stopped state. Saving this information also allows
to remove several register reads from the RIO enumeration process.

Why not keep using the swpinfo field, as you can extract it from there? And your code actually does this.

Also processor devices can have multiple ports (not only switches), it would be good to be ready for that use case.

Micha

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/