Re: [PATCH] 2.6.35 libata support for > 512 byte sectors (e.g. 4K Native)

From: Grant Grundler
Date: Mon Aug 16 2010 - 16:24:26 EST


On Mon, Aug 16, 2010 at 12:41 PM, Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
...
> The main question is whether the size of a DRQ block changes, when LBA
> logical size changes?

Don't we already know that depends on the ATA command?

> I need to review the ATA8 specs in this area, but I
> would think some interfaces that return 512-byte pages for things like SMART
> info would be unchanged. ÂHow do the drives behave for PIO-Data-{In,Out}
> commands that are not reading/writing user data, but rather drive metadata?

SMART Info/Logs are meta data and as you noted unchanged.

Two other meta-data PIO commands I can think of:
o FW update: I'm not going to risk bricking this drive to find that out.
o Vendor specific selftest/diagnostic commands (I don't know if any
exist - just a guess)

If someone from Hitachi cares to respond publicly regarding the
behavior of this "Engineering Sample", that would be appreciated and
helpful. But feedback from any other vendor would be welcome/useful
also.

I suspect legacy tools might be needed to update firmware and those
might continue to function if DRQ block size is still 512 byte. I'd
like to leave this hardcoded to ATA_SECT_SIZE until someone can
demonstrate a need to change it. Ok?

thanks,
grant
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/