Re: [PATCH] kconfig: Fix variable name typo instreamline_config.pl.

[Steven Rostedt]

On Tue, 2010-08-17 at 19:49 +0900, hiromu wrote:
> On Fri, Aug 17, 2010 at 01:43PM +0800, Américo Wang wrote:
> > Acked-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>
> > 
> > BTW, I think we should add "use strict;" too.
> 
> Then I added "use strict;" to streamline_config.pl, I saw another
> warings.
> 
> > Global symbol "$dir" requires explicit package name at
> scripts/kconfig/streamline_config.pl line 286.
> > Global symbol "$dir" requires explicit package name at
> scripts/kconfig/streamline_config.pl line 287.
> > Global symbol "$dir" requires explicit package name at
> scripts/kconfig/streamline_config.pl line 288.
> 
> Then I added "my $dir;" to line 285.

Thanks! I'll pull this in today.

-- Steve

> 
> Cc: Américo Wang <xiyou.wangcong@xxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Toralf Foerster <toralf.foerster@xxxxxx>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> Cc: YOSHIFUJI Hideaki <yoshfuji@xxxxxxxxxxxxxx>
> 
> Signed-off-by: Hiromu Yakura <hiromu1996@xxxxxxxxx>
> ---
>  scripts/kconfig/streamline_config.pl |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/kconfig/streamline_config.pl
> b/scripts/kconfig/streamline_config.pl
> index d74363f..9ca361a 100644
> --- a/scripts/kconfig/streamline_config.pl
> +++ b/scripts/kconfig/streamline_config.pl
> @@ -42,6 +42,8 @@
>  #    mv config_strip .config
>  #    make oldconfig
>  #
> +use strict;
> +
>  my $config = ".config";
>  
>  my $uname = `uname -r`;
> @@ -280,6 +282,7 @@ if (defined($lsmod_file)) {
>  
>      # see what modules are loaded on this system
>      my $lsmod;
> +    my $dir;
>  
>      foreach $dir ( ("/sbin", "/bin", "/usr/sbin", "/usr/bin") ) {
>         if ( -x "$dir/lsmod" ) {


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/