Re: [PATCH 2/2] oom: fix tasklist_lock leak

From: David Rientjes
Date: Thu Aug 19 2010 - 16:37:29 EST


On Thu, 19 Aug 2010, KOSAKI Motohiro wrote:

> commit 0aad4b3124 (oom: fold __out_of_memory into out_of_memory)
> introduced tasklist_lock leak. Then it caused following obvious
> danger warings and panic.
>
> ================================================
> [ BUG: lock held when returning to user space! ]
> ------------------------------------------------
> rsyslogd/1422 is leaving the kernel with locks still held!
> 1 lock held by rsyslogd/1422:
> #0: (tasklist_lock){.+.+.+}, at: [<ffffffff810faf64>] out_of_memory+0x164/0x3f0
> BUG: scheduling while atomic: rsyslogd/1422/0x00000002
> INFO: lockdep is turned off.
>
> This patch fixes it.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/