Re: oom: __task_cred() need rcu_read_lock()

From: KOSAKI Motohiro
Date: Thu Aug 19 2010 - 20:09:03 EST


Hi

> KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:
>
> > dump_tasks() can call __task_cred() safely because we are holding
> > tasklist_lock. but rcu lock validator don't have enough knowledge and
> > it makes following annoying warning.
>
> No, it can't. The tasklist_lock is not protection against the creds changing
> on another CPU.

Thank you for correction.

I suppose you mean I missed CONFIG_TREE_PREEMPT_RCU, right?
As far as my grepping, other rcu implementation and spinlock use
preempt_disable(). In other word, Can I assume usual distro user
don't hit this issue?

Thanks.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/