Re: [PATCH 1/1] mutex: prevent optimistic spinning from spinninglonger than neccessary (Repost)

From: Ingo Molnar
Date: Fri Aug 20 2010 - 09:19:45 EST



* Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx> wrote:

> > Ingo wrote:
> >
> > These are some rather impressive speedups!
> >
> > Have you tried to see what performance effects this change has on
> smaller
> > boxes? Just to see what flip side (if any) this change has.
> >
>
> I've done similar experiments with 2.6.35 kernel on smaller boxes. One is
> on a dual-socket Westmere box (12 cores total, with HT). Another
> experiment is on an old dual-socket Core 2 box (4 cores total, no HT)
>
> On the 12-core Westmere box, I see a 250% increase for Ingo's mutex-test
> program with my mutex patch but no significant difference in aim7's
> fserver workload.
>
> On the 4-core Core 2 box, I see the difference with the patch for both
> mutex-test and aim7 fserver are negligible.

Great!

> So far, it seems like the patch has not caused regression on smaller
> systems. We'll put it through more workloads to check.

Thanks! The performance results you've posted so far IMO more than justifies
its inclusion.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/