RE: [PATCH 2/2] drivers/serial/bfin_5xx.c: Use pr_<level> and pr_<fmt>

[Joe Perches]

On Tue, 24 Aug 2010, Zhang, Sonic wrote:
> >Also fix typo of length.
> >Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> >-		pr_info("Unable to attach BlackFin UART Modem "
> >-			"Status interrupt.\n");
> >+		pr_info("Unable to attach BlackFin UART Modem
> >Status interrupt\n");
> I don't this this change is necessary.

Linus once said he doesn't like splitting
format lines because it makes grep more
difficult.

http://lkml.org/lkml/2009/12/17/229

> How about following style?
>
> 			pr_warning( "STOP bits other than 1 is not "
> 				"supported in case of anomaly
> 05000231.\n");

Fix it up as you prefer.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/