Re: [PATCH 0/4] Finer granularity and task/cgroup irq timeaccounting

From: Martin Schwidefsky
Date: Tue Aug 24 2010 - 08:48:09 EST


On Tue, 24 Aug 2010 13:53:55 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Tue, 2010-08-24 at 17:08 +0530, Balbir Singh wrote:
> >
> > The point is for containers it is more likely to give the right answer
> > and so on. Yes, the results are not 100% accurate.
>
> Consider one group heavily dirtying pages, it stuffs the IO queues full
> and gets blocked on IO completion. Since the CPU is then free to
> schedule something else we start running things from another group,
> those IO completions will come in while we run other group and get
> accounted to other group -- FAIL.
>
> s/group/task/ etc..
>
> That just really doesn't work, accounting async work, esp stuff that is
> not under software control it very tricky indeed.
>
> So what are you wanting to do, and why. Do you really need accounting
> madness?

Well, I have sent a patch back in 2006 that stops adding the hardirq /
softirq time to the currently running process. See
http://lkml.org/lkml/2006/8/24/139
It did not get very far, so that answer to the question if we need
accounting madness seems to be yes ..

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/