Re: [PATCH] avoiding the same resource to be inserted

[Andrew Morton]

On Wed, 25 Aug 2010 13:03:55 +0800 Huang Shijie <shijie8@xxxxxxxxx> wrote:

> On Wed, Aug 25, 2010 at 7:46 AM, Andrew Morton
> <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> I think WARN_ON() is not power enough. If the CONFIG_BUG is not
> defined, the warning message may not be printed. So I think using a
> directly printk() here is better.

No, WARN_ON() is good.  It gives us a backtrace and identifies the
buggy code.  Only maniacs turn off CONFIG_BUG.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/