Re: [PATCH] workqueue: fix cwq->nr_active underflow

[Tejun Heo]

On 08/25/2010 04:25 PM, Johannes Berg wrote:
> On Wed, 2010-08-25 at 11:12 +0200, Tejun Heo wrote:
> 
>> Yeap, without the fix patch applied, that should confirm that we're
>> seeing the same failure, and with the patch applied, you can add a
>> printk in the else part of !delayed check in cwq_dec_nr_in_flight().
>> If the printk triggers and later rmmod dosen't trigger BUG_ON(), we
>> can be fairly sure the problem is fixed.
> 
> Unfortunately, I haven't been able to trigger either code path today.
> I'll happily believe that this was the problem though, and will just let
> you know if I run into it again, I'm keeping the debug patch for now.
> It's certainly a valid fix regardless of whether I can reproduce the
> problem or not.

Thanks.  I'll push it to Linus tomorrow.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/