Re: [PATCH] Add new linearfb driver

From: Colin Watson
Date: Wed Aug 25 2010 - 13:29:01 EST


On Wed, Aug 25, 2010 at 07:04:38PM +0200, Bruno Prémont wrote:
> On Wed, 25 August 2010 Colin Watson <cjwatson@xxxxxxxxxxxxx> wrote:
> > -config FB_EFI
> > - bool "EFI-based Framebuffer Support"
> > - depends on (FB = y) && X86 && EFI
> > +config FB_LINEAR
> > + bool "Simple linear framebuffer support"
> > + depends on FB
> > select FB_CFB_FILLRECT
> > select FB_CFB_COPYAREA
> > select FB_CFB_IMAGEBLIT
> ^^^^^^^^^^^^^^^^^^^^^^^
>
> > +config FB_EFI
> > + bool "EFI-based Framebuffer Support"
> > + depends on (FB = y) && X86 && EFI
> > + select FB_LINEAR
> ^^^^^^^^^^^^^^^^
> Has kconfig been adjusted to process select recursively?
> If not the selects from FB_LINEAR will have to be copied here.

When I start with a consistent .config with FB_CFB_FILLRECT unset, then
'make menuconfig' and enable FB_EFI, the resulting .config has
CONFIG_FB_CFB_FILLRECT=y. That should be a sufficient test, shouldn't
it?

Thanks,

--
Colin Watson [cjwatson@xxxxxxxxxxxxx]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/