Re: [RFC patch (against wireless-next)] include/net/cfg80211.h:wiphy_<level> messages use dev_printk

[John W. Linville]

On Fri, Aug 20, 2010 at 03:13:59PM -0700, Joe Perches wrote:
> On Thu, 2010-08-19 at 21:39 +0200, Johannes Berg wrote:
> > On Thu, 2010-08-19 at 12:24 -0700, Joe Perches wrote:
> > > Adding device to the wiphy logging messages could be useful.
> > >  #define wiphy_printk(level, wiphy, format, args...)		\
> > > -	printk(level "%s: " format, wiphy_name(wiphy), ##args)
> > > +	dev_printk(level, &wiphy->dev, "%s: " format, wiphy_name(wiphy), ##args)
> > what will that actually print?
> 
> As is, that'd print:
> 
> "<level>dev_driver_string(&wiphy->dev) dev_name(&wiphy->dev): wiphy_name(wiphy): " fmt, ##args
> 
> for instance:
> 
> [   41.261941] ieee80211 phy0: phy0: Selected rate control algorithm 'minstrel_ht'
> 
> ie: redundant.
> wiphy_name(wiphy) is an inline for dev_name(&wiphy->dev)
> 
> So it's appropriate to use:
> 
> #define wiphy_<level>(wiphy, fmt, arg...) dev_<level>(&wiphy->dev, fmt, ##arg) 
> 
> and the output becomes:
> 
> [   41.261941] ieee80211 phy0: Selected rate control algorithm 'minstrel_ht'
> 
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

Everyone OK w/ this version?

-- 
John W. Linville		Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/