Re: [PATCH] x86: EuroBraille/Iris power off

[H. Peter Anvin]

On 08/25/2010 02:12 PM, Sebastien Hinderer wrote:
> Hi,
> 
>> excellent! Now if as the next step before inclusion you also add the usual DMI check
>> (as done by many drivers such as acerhdf etc.),
>> someone inexperienced who is dumb enough to enable it for his unrelated machine
>> will actually survive an otherwise raw I/O port access and poweroff
>> vector change ;))
> 
> The machine does not support DMI, I have mentionned that in the module.
> 

Perhaps a better questions is: what *do* they have?  I really don't feel
comfortable adding something like this which pokes at a random port in
the ISA range, especially with the Interrupt list listing 6 known other
uses of this particular port.

At that point I'd almost prefer doing something like a BIOS signature
check if we can't do anything better.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/