Re: [PATCH] Drivers: firewire: Fixed coding style for all thefiles in the directory

[Joe Perches]

On Wed, 2010-08-25 at 23:24 +0200, Stefan Richter wrote:
> Rotari Razvan-Gabriel wrote:
[]
> > +++ b/drivers/firewire/core-card.c
> > @@ -107,7 +107,7 @@ static void generate_config_rom(struct fw_card *card, __be32 *config_rom)
> >  	j = 7 + descriptor_count;
> > 
> >  	/* Generate root directory entries for descriptors. */
> > -	list_for_each_entry (desc, &descriptor_list, link) {
> > +	list_for_each_entry(desc, &descriptor_list, link) {
> >  		if (desc->immediate > 0)
> >  			config_rom[i++] = cpu_to_be32(desc->immediate);
> >  		config_rom[i] = cpu_to_be32(desc->key | (j - i));
> 
> Not a fix.

Perhaps you could consider it a consistency change for easier grepping

$ grep -rPoh --include=*.[ch] "\blist_for\w+\s*\(" drivers/firewire | sort | uniq -c
      3 list_for_each_entry (
     21 list_for_each_entry(
     10 list_for_each_entry_safe(



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/