Re: [PATCH] gpio: Add generic driver for simple memory mappedcontrollers

[Mark Brown]

On Wed, Aug 25, 2010 at 11:42:49PM +0400, Anton Vorontsov wrote:

> +	res_dat = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res_dat)
> +		return -EINVAL;

I'd suggest naming these resources rather than grabbing by number,
that'll make it easier to plumb the machine driver side in since you
don't have to remember which number corresponds to which function.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/