Re: [PATCH v2] gpio: Add driver for Anton GPIO controllers

[David Brownell]

--- On Thu, 8/26/10, Anton Vorontsov <cbouatmailru@xxxxxxxxx> wrote:

> From: Anton Vorontsov <cbouatmailru@xxxxxxxxx>
> Subject: Re: [PATCH v2] gpio: Add driver for Anton GPIO controllers
> To: "David Brownell" <david-b@xxxxxxxxxxx>
> Cc: "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>, "Samuel Ortiz" <sameo@xxxxxxxxxxxxxxx>, "Mark Brown" <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>, "David Brownell" <dbrownell@xxxxxxxxxxxxxxxxxxxxx>, "Alan Cox" <alan@xxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
> Date: Thursday, August 26, 2010, 2:20 PM
> On Thu, Aug 26, 2010 at 10:57:33AM
> -0700, David Brownell wrote:
> [...]
>  
> You seemed to be fine with meaningless amba-9999
> or dw_abc names, but 

NOT meaningless ... when there's actual IP behind
the controller!  Which, at first, is what I thought
you were talking about.


> Just kiding, of course. basic_mmio.c works for me.

OK, how about resubmitting?  With that name?

Be sure to add a bit of documentation about 
the controller requirements  ... basically that
it has a register from which all values can be
read, and that either that register can be written,
or there's a pair of set-bit/clear-bit registers
affecting that register and the output pins.

Might be worth mentioning how trivial it is to do
that in hardware like CPLDs/FPGAS/etc, which is
why this handles different word sizes/endianness.
and the expectation that in at least some cases
this will be used with roll-your-own ASIC/FPGA
logic in Verilog or VHDL (yes?).

> I also think it makes sense to drop gpio_ prefix,
> as the driver is already in gpio/ directory.

No, keep it; files move around sometimes, and it's
best if that loses no information.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/